Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename llm-instance-gateway registry to gateway-api-inference-extension #7657

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Jan 5, 2025

Fixes #7636

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure labels Jan 5, 2025
@upodroid upodroid added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure labels Jan 5, 2025
@k8s-ci-robot k8s-ci-robot added the area/registry.k8s.io Code in registry.k8s.io/ label Jan 5, 2025
@k8s-ci-robot k8s-ci-robot requested review from dims and xmudrii January 5, 2025 14:45
@k8s-ci-robot k8s-ci-robot added area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 5, 2025
@upodroid
Copy link
Member Author

upodroid commented Jan 5, 2025

/cc @ahg-g @kfswain

@k8s-ci-robot k8s-ci-robot requested review from ahg-g and kfswain January 5, 2025 14:46
@k8s-infra-ci-robot
Copy link
Contributor

Ran Plan for dir: infra/gcp/terraform/k8s-staging-images workspace: default

Show Output
Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply" which may have affected this plan:

  # module.artifact_registry["charts"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/charts"
        name                   = "charts"
      ~ update_time            = "2024-12-06T15:33:54.572945Z" -> "2025-01-03T18:58:03.944142Z"
        # (10 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["cloud-provider-kind"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/cloud-provider-kind"
        name                   = "cloud-provider-kind"
      ~ update_time            = "2024-11-25T21:04:11.526859Z" -> "2024-12-20T12:17:06.334981Z"
        # (10 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["csi-vsphere"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/csi-vsphere"
        name                   = "csi-vsphere"
      ~ update_time            = "2024-12-05T20:52:14.327242Z" -> "2025-01-03T10:40:07.797496Z"
        # (10 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["etcd-manager"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/etcd-manager"
        name                   = "etcd-manager"
      ~ update_time            = "2024-12-02T21:07:31.873341Z" -> "2024-12-27T19:28:34.420339Z"
        # (10 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["kueue"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/kueue"
        name                   = "kueue"
      ~ update_time            = "2024-12-06T15:32:42.661798Z" -> "2025-01-03T19:18:01.054362Z"
        # (10 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }


Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

─────────────────────────────────────────────────────────────────────────────

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
- destroy

Terraform will perform the following actions:

  # module.artifact_registry["gateway-api-inference-extension"].google_artifact_registry_repository.repo will be created
+ resource "google_artifact_registry_repository" "repo" {
      + cleanup_policy_dry_run = false
      + create_time            = (known after apply)
      + effective_labels       = {
          + "goog-terraform-provisioned" = "true"
        }
      + format                 = "DOCKER"
      + id                     = (known after apply)
      + location               = "us-central1"
      + mode                   = "STANDARD_REPOSITORY"
      + name                   = (known after apply)
      + project                = "k8s-staging-images"
      + repository_id          = "gateway-api-inference-extension"
      + terraform_labels       = {
          + "goog-terraform-provisioned" = "true"
        }
      + update_time            = (known after apply)

      + cleanup_policies {
          + action = "DELETE"
          + id     = "delete-images-older-than-90-days"

          + condition {
              + older_than            = "7776000s"
              + package_name_prefixes = []
              + tag_prefixes          = []
              + tag_state             = "ANY"
              + version_name_prefixes = []
            }
        }
    }

  # module.artifact_registry["gateway-api-inference-extension"].google_artifact_registry_repository_iam_member.readers["allUsers"] will be created
+ resource "google_artifact_registry_repository_iam_member" "readers" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + location   = "us-central1"
      + member     = "allUsers"
      + project    = "k8s-staging-images"
      + repository = (known after apply)
      + role       = "roles/artifactregistry.reader"
    }

  # module.artifact_registry["gateway-api-inference-extension"].google_artifact_registry_repository_iam_member.writers["group:[email protected]"] will be created
+ resource "google_artifact_registry_repository_iam_member" "writers" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + location   = "us-central1"
      + member     = "group:[email protected]"
      + project    = "k8s-staging-images"
      + repository = (known after apply)
      + role       = "roles/artifactregistry.writer"
    }

  # module.artifact_registry["llm-instance-gateway"].google_artifact_registry_repository.repo will be destroyed
  # (because module.artifact_registry["llm-instance-gateway"] is not in configuration)
- resource "google_artifact_registry_repository" "repo" {
      - cleanup_policy_dry_run = false -> null
      - create_time            = "2024-11-24T15:13:02.377922Z" -> null
      - effective_labels       = {} -> null
      - format                 = "DOCKER" -> null
      - id                     = "projects/k8s-staging-images/locations/us-central1/repositories/llm-instance-gateway" -> null
      - labels                 = {} -> null
      - location               = "us-central1" -> null
      - mode                   = "STANDARD_REPOSITORY" -> null
      - name                   = "llm-instance-gateway" -> null
      - project                = "k8s-staging-images" -> null
      - repository_id          = "llm-instance-gateway" -> null
      - terraform_labels       = {} -> null
      - update_time            = "2025-01-04T00:24:49.280174Z" -> null

      - cleanup_policies {
          - action = "DELETE" -> null
          - id     = "delete-images-older-than-90-days" -> null

          - condition {
              - older_than            = "7776000s" -> null
              - package_name_prefixes = [] -> null
              - tag_prefixes          = [] -> null
              - tag_state             = "ANY" -> null
              - version_name_prefixes = [] -> null
            }
        }
    }

  # module.artifact_registry["llm-instance-gateway"].google_artifact_registry_repository_iam_member.readers["allUsers"] will be destroyed
  # (because module.artifact_registry["llm-instance-gateway"] is not in configuration)
- resource "google_artifact_registry_repository_iam_member" "readers" {
      - etag       = "BwYnqg30B5k=" -> null
      - id         = "projects/k8s-staging-images/locations/us-central1/repositories/llm-instance-gateway/roles/artifactregistry.reader/allUsers" -> null
      - location   = "us-central1" -> null
      - member     = "allUsers" -> null
      - project    = "k8s-staging-images" -> null
      - repository = "projects/k8s-staging-images/locations/us-central1/repositories/llm-instance-gateway" -> null
      - role       = "roles/artifactregistry.reader" -> null
    }

  # module.artifact_registry["llm-instance-gateway"].google_artifact_registry_repository_iam_member.writers["group:[email protected]"] will be destroyed
  # (because module.artifact_registry["llm-instance-gateway"] is not in configuration)
- resource "google_artifact_registry_repository_iam_member" "writers" {
      - etag       = "BwYnqg30B5k=" -> null
      - id         = "projects/k8s-staging-images/locations/us-central1/repositories/llm-instance-gateway/roles/artifactregistry.writer/group:[email protected]" -> null
      - location   = "us-central1" -> null
      - member     = "group:[email protected]" -> null
      - project    = "k8s-staging-images" -> null
      - repository = "projects/k8s-staging-images/locations/us-central1/repositories/llm-instance-gateway" -> null
      - role       = "roles/artifactregistry.writer" -> null
    }

Plan: 3 to add, 0 to change, 3 to destroy.
  • ▶️ To apply this plan, comment:
    atlantis apply -d infra/gcp/terraform/k8s-staging-images
  • 🚮 To delete this plan and lock, click here
  • 🔁 To plan this project again, comment:
    atlantis plan -d infra/gcp/terraform/k8s-staging-images

Note: Objects have changed outside of Terraform
Plan: 3 to add, 0 to change, 3 to destroy.


  • ⏩ To apply all unapplied plans from this Pull Request, comment:
    atlantis apply
  • 🚮 To delete all plans and locks from this Pull Request, comment:
    atlantis unlock

@stmcginnis
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2025
@kfswain
Copy link

kfswain commented Jan 15, 2025

/lgtm

Thanks!

@kfswain
Copy link

kfswain commented Jan 15, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2025
@ahg-g
Copy link
Member

ahg-g commented Jan 15, 2025

/lgtm

Thanks for fixing this!

@kfswain
Copy link

kfswain commented Jan 15, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5091a5a into kubernetes:main Jan 15, 2025
6 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 15, 2025
@k8s-infra-ci-robot
Copy link
Contributor

Locks and plans deleted for the projects and workspaces modified in this pull request:

  • dir: infra/gcp/terraform/k8s-staging-images workspace: default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/registry.k8s.io Code in registry.k8s.io/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename llm-instance-gateway registry to gateway-api-inference-extension
6 participants